Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: move and update functions related to placement to util/placement.go #1810

Open
parikshithb opened this issue Feb 5, 2025 · 0 comments · May be fixed by #1833
Open

e2e: move and update functions related to placement to util/placement.go #1810

parikshithb opened this issue Feb 5, 2025 · 0 comments · May be fixed by #1833
Assignees
Labels
test Testing related issue

Comments

@parikshithb
Copy link
Member

parikshithb commented Feb 5, 2025

To improve logging clarity in e2e, we need to refactor the functions responsible for retrieving the current and target clusters. These functions are currently private and located in dractions/retry.go. The goal is to make them public and relocate them to a new file, util/placement.go. This change will help standardize cluster placement logic across deployer types and ensure consistent logging for failover, and relocate actions.

Tasks:

  • Identify all functions related to retrieving the current and target clusters in dractions/retry.go.
  • Move/refactor these functions to a new file, util/placement.go.
  • Make the functions public to allow access from other packages.
  • Update existing code to reference the new public functions.
  • Verify that e2e logs correctly display the current and target clusters during failover, and relocate actions.
@parikshithb parikshithb self-assigned this Feb 5, 2025
@nirs nirs added the test Testing related issue label Feb 6, 2025
@parikshithb parikshithb changed the title e2e: move functions related to placement to util/placement.go e2e: move and update functions related to placement to util/placement.go Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants