Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Guidelines #9554

Open
Soheab opened this issue Sep 7, 2023 · 2 comments
Open

Extension Guidelines #9554

Soheab opened this issue Sep 7, 2023 · 2 comments
Labels
feature request This is a feature request.

Comments

@Soheab
Copy link
Contributor

Soheab commented Sep 7, 2023

Summary

Guidelines for second/third-party extensions

What is the feature request for?

The documentation

The Problem

From what I can understand, the discord/ext namespace is open for users to "inject" their addons to the library for things that are potentially missing or something else but I can't seem to find any guidelines on what such extension should follow. Like best practices, do's and don'ts, etc.

The Ideal Solution

Provide / Write guidelines for using the discord/ext namespace. Some things I can think of are as follows:

  • Typing, should extensions be typed to comply to maintain quality etc...
  • Exceptions, should extensions provide a base exception to handle all errors etc...
  • Import from library, what can extensions import from the main lib (discord/...) and what not etc...
  • etc...

The Current Solution

You can ask around / regulars/contributors in the discord.py server. I guess.

Additional Context

No response

@Soheab Soheab added the feature request This is a feature request. label Sep 7, 2023
@EvieePy
Copy link
Contributor

EvieePy commented Sep 7, 2023

As far as guidelines around all the things mentioned, I don't think it would be appropriate to set rules on how people develop their software. Third-Party extensions are not official and are created by members of the community; they are used much like any other installable python package, for the most part. Typing, exceptions etc etc are all responsibilities and choices made by the creators, and it's up to the end user to decide whether they want to use these extensions or not.

@Soheab
Copy link
Contributor Author

Soheab commented Sep 7, 2023

As far as guidelines around all the things mentioned, I don't think it would be appropriate to set rules on how people develop their software. Third-Party extensions are not official and are created by members of the community; they are used much like any other installable python package, for the most part. Typing, exceptions etc etc are all responsibilities and choices made by the creators, and it's up to the end user to decide whether they want to use these extensions or not.

That is fair, but I think of it as a PEP8 kind of thing where creators can follow it but are not forced to. The library provides the ability and I think it's only good to also provide some sort of good practices guide for it. I do agree that my example points are kind of silly now that I think about it.

The guide could potentially also be used to differentiate between good and bad extensions and maybe recommend them on the server or showcase them somewhere instead of shitting on them (I know, a guide isn't going to help with that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This is a feature request.
Projects
None yet
Development

No branches or pull requests

2 participants