Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation #221

Closed
mjohnson541 opened this issue Jun 29, 2023 · 4 comments
Closed

Fix documentation #221

mjohnson541 opened this issue Jun 29, 2023 · 4 comments

Comments

@mjohnson541
Copy link
Collaborator

As per issue #220. We need to change the documentation calls from domain,y0 = ConstantTVDomain(phase=liq,initialconds=initialconds,constantspecies=["oxygen"]) to domain,y0,p = ConstantTVDomain(phase=liq,initialconds=initialconds,constantspecies=["oxygen"])
@mjohnson541
Copy link
Collaborator Author

It looks like we already made these modifications. Something must be wrong with docs deployment.

@mjohnson541
Copy link
Collaborator Author

Seems like at some point we stopped updating gh-pages and the online documentation stopped changing.

@mjohnson541
Copy link
Collaborator Author

mjohnson541 commented Jun 29, 2023 •
edited
Loading

I'm wondering a bit if Documenter.jl is hard coded somewhere to use master and that we broke this system when we switched to main...I've updated master to current main to see if that helps, but I am unable to test currently with the environment issues after the changes in RMG.

@mjohnson541
Copy link
Collaborator Author

Resolved with #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjohnson541