Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Search Messages crashes on 429 from server #974

Open
Abbas-Askari opened this issue Feb 10, 2025 · 0 comments · May be fixed by #975
Open

bug: Search Messages crashes on 429 from server #974

Abbas-Askari opened this issue Feb 10, 2025 · 0 comments · May be fixed by #975
Labels
bug Something isn't working

Comments

@Abbas-Askari
Copy link

Description:

TypeError: Cannot read properties of undefined (reading 'length') appears when too many search requests are sent back to back in Search Messages Sidebar

Steps to reproduce:

  1. Goto https://rocketchat.github.io/EmbeddedChat/?path=/story/embeddedchat-simple--simple
  2. Open Search Messages sidebar
  3. Search repeatedly until the server returns 429.
  4. Observer the TypeError: Cannot read properties of undefined (reading 'length')

Expected behavior:

No error should appear.

Actual behavior:

Network tab on the right side is showing requests:

Screencast.from.2025-02-11.00-15-37.webm
@Abbas-Askari Abbas-Askari added the bug Something isn't working label Feb 10, 2025
Abbas-Askari added a commit to Abbas-Askari/EmbeddedChat that referenced this issue Feb 10, 2025
@Abbas-Askari
fix: Search Messages crashes on 429 from server RocketChat#974
fc5351c
Abbas-Askari added a commit to Abbas-Askari/EmbeddedChat that referenced this issue Feb 10, 2025
@Abbas-Askari
fix: Search Messages crashes on 429 from server RocketChat#974
9dd370f
Abbas-Askari added a commit to Abbas-Askari/EmbeddedChat that referenced this issue Feb 10, 2025
@Abbas-Askari
fix: Search Messages crashes on 429 from server RocketChat#974
81acd5e
@Abbas-Askari Abbas-Askari linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Search Messages crashes on 429 from server #974 Abbas-Askari/EmbeddedChat
1 participant
@Abbas-Askari