Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option for custom annotations #481

Open
gi02sap opened this issue Nov 4, 2024 · 2 comments
Open

Feature request: Add option for custom annotations #481

gi02sap opened this issue Nov 4, 2024 · 2 comments

Comments

@gi02sap
Copy link

gi02sap commented Nov 4, 2024

Hi colleagues,

I am using the btp-operator in a setup where it (among other microservices) is deployed via ArgoCD.
The parameters I use in the secret are imported from Hashicorp Vault via the ArgoCD Vault Plugin. Its' functionality relies on a certain annotation of the secret template and the current version of the secret doesn't provide the option to add this annotation:
https://argocd-vault-plugin.readthedocs.io/en/stable/howitworks/

With few simple changes of the secret template and the values file we can add the option for custom annotations.

@kerenlahav
Copy link
Contributor

Hi @gi02sap
please provide the tempalte with the required changes and we'll review it.
Thanks!

@gi02sap
Copy link
Author

gi02sap commented Nov 4, 2024

Hi @kerenlahav, |
Here's the PR, I've just raised.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants