Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating a service instance with watchParametersFromChanges parameter is not successful #502

Open
i330963 opened this issue Jan 30, 2025 · 5 comments
Open

Updating a service instance with watchParametersFromChanges parameter is not successful #502

i330963 opened this issue Jan 30, 2025 · 5 comments

Comments

@i330963
Copy link

i330963 commented Jan 30, 2025 •
edited
Loading

We are unable to successfully apply the newly released watchParametersFromChanges parameter to the cloud logging service instance. There is no much logs provided by the BTP Operator pod except the below:

2025-01-30T14:33:00.219487444Z 2025-01-30T14:33:00Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "e9aba6e1-0615-41ea-b743-b0c08abe80fb"}
2025-01-30T14:33:00.189727100Z 2025-01-30T14:33:00Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "c822efd4-34d5-4cf0-8191-b744af323a25"}
2025-01-30T14:33:00.151203973Z 2025-01-30T14:33:00Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:33:00.119020846Z 2025-01-30T14:33:00Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:33:00.037104365Z 2025-01-30T14:33:00Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:59.997172669Z 2025-01-30T14:32:59Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:50.190836952Z 2025-01-30T14:32:50Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "fbffa9b4-bbae-4ee7-8415-493e3d36d64a"}
2025-01-30T14:32:50.161844081Z 2025-01-30T14:32:50Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "174e7838-05ef-409d-8628-a0eb35cb0ddc"}
2025-01-30T14:32:50.133985901Z 2025-01-30T14:32:50Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:50.108764001Z 2025-01-30T14:32:50Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:50.035620663Z 2025-01-30T14:32:50Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:50.009032870Z 2025-01-30T14:32:50Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:44.733378725Z 2025-01-30T14:32:44Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "ba7d58be-6d06-433d-b648-0bafa188121d"}
2025-01-30T14:32:44.704824775Z 2025-01-30T14:32:44Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "1a46a74e-313b-443c-b555-9a891348882a"}
2025-01-30T14:32:44.676815789Z 2025-01-30T14:32:44Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:44.652293402Z 2025-01-30T14:32:44Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:44.578928451Z 2025-01-30T14:32:44Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:44.548576246Z 2025-01-30T14:32:44Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:16.245902370Z 2025-01-30T14:32:16Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "d00f949e-4f20-4c42-8eae-182638b43818"}
2025-01-30T14:32:16.216867163Z 2025-01-30T14:32:16Z INFO controllers.ServiceInstance instance is in final state (generation: 5) {"serviceinstance": {"name":"rage-cloud-logging","namespace":"rage"}, "correlation_id": "09c4ab14-5af7-4d76-8b88-01ec4af30277"}
2025-01-30T14:32:16.185668164Z 2025-01-30T14:32:16Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:16.121796292Z 2025-01-30T14:32:16Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance
2025-01-30T14:32:16.055339388Z 2025-01-30T14:32:16Z INFO serviceinstance-resource validate update {"name": "rage-cloud-logging"}
2025-01-30T14:32:15.870489698Z 2025-01-30T14:32:15Z INFO serviceinstance-webhook Defaulter webhook for serviceinstance

ArgoCD does not show any logs and it basically sets the resource as out of sync:

Image
Image

YAML defeniton of the service instance:

apiVersion: services.cloud.sap.com/v1alpha1
kind: ServiceInstance
metadata:
  name: rage-cloud-logging
  namespace: {{ .Values.namespace }}
  annotations:
    services.cloud.sap.com/preventDeletion: "true"
spec:
  serviceOfferingName: cloud-logging
  servicePlanName: {{ .Values.cloudLoggingPlan }}
  externalName: rage-cloud-logging
  parameters:
    retentionPeriod: {{ .Values.retentionPeriod }}
    esApiEnabled: false
    ingest_otlp:
      enabled: true
  parametersFrom:
    - secretKeyRef:
        name: logging-secret
        key: signature-secret-parameters
  watchParametersFromChanges: true
@I065450
Copy link
Collaborator

I065450 commented Feb 2, 2025

what is the instance status?

@i330963
Copy link
Author

i330963 commented Feb 2, 2025

what is the instance status?

The update operation did not get triggered at all, means it did not reach the instance. I was looking between ArgoCD & BTP Cockpit trying during the testing.

Image

The instance was updated successfully as you can see below but this update was done explicitly by me to test if the update operation works in first place and after several unsuccessful retries with the watchParametersFromChanges parameter.

status:
  conditions:
    - lastTransitionTime: '2025-01-30T14:12:59Z'
      message: ServiceInstance updated successfully
      observedGeneration: 5
      reason: Updated
      status: 'True'
      type: Succeeded
    - lastTransitionTime: '2024-06-14T14:57:29Z'
      message: ServiceInstance updated successfully
      observedGeneration: 5
      reason: Provisioned
      status: 'True'
      type: Ready
  hashedSpec: fc1d1b2374c88a96f4cc34b2c17d4bf7
  instanceID: f3dc4b96-5052-49fe-aa3e-114e5c8dcc67
  ready: 'True'
  tags:
    - Cloud Logging

Also while trying with watchParametersFromChanges parameter, I supposed to see it reflected in Kyma but it does not:

Image

@I065450
Copy link
Collaborator

I065450 commented Feb 3, 2025

The instance suppose to be updated only when the secret have changed,
Did you update the secret?

@i330963
Copy link
Author

i330963 commented Feb 3, 2025 •
edited
Loading

The instance suppose to be updated only when the secret have changed, Did you update the secret?

no, I did not change the secret but shouldn't the variable get reflected in the list of instance´s parameters?

@I065450
Copy link
Collaborator

I065450 commented Feb 3, 2025

it is not part of the instance parameters.
it used by the operator to trigger update event in case of secret update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i330963 @I065450