New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW19- TA comment #1

Open

sherrie9 opened this issue Dec 10, 2018 · 0 comments

sherrie9 commented Dec 10, 2018

Overall, good job for doing basic web API,
good

good table manipulations!

Some suggestions

variable names are hard to understand. try to use more informative names rather than "eBAKhs", etc.
You used two methods to scrap data and split them to two separate files. However, it could be better if these two methods were compared in a single md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment