From 669d099e15e57a40a6e9457ab758770a1b183181 Mon Sep 17 00:00:00 2001 From: Maja Zarkova Date: Mon, 26 Aug 2024 16:14:47 +0300 Subject: [PATCH 01/21] Remove/rename click event on every component --- .../sit-onyx/src/components/OnyxButton/OnyxButton.vue | 8 -------- .../src/components/OnyxIconButton/OnyxIconButton.vue | 6 ------ packages/sit-onyx/src/components/OnyxLink/OnyxLink.vue | 8 -------- .../src/components/OnyxNavAppArea/OnyxNavAppArea.vue | 10 +--------- .../OnyxNavBar/modules/OnyxMenuItem/OnyxMenuItem.vue | 8 -------- .../OnyxNavBar/modules/OnyxNavButton/OnyxNavButton.vue | 6 +++--- .../OnyxNavBar/modules/OnyxNavItem/OnyxNavItem.vue | 4 ++-- .../sit-onyx/src/components/OnyxSelect/OnyxSelect.vue | 2 +- .../src/components/OnyxSelectInput/OnyxSelectInput.vue | 4 ++-- .../components/OnyxToastMessage/OnyxToastMessage.vue | 4 ++-- 10 files changed, 11 insertions(+), 49 deletions(-) diff --git a/packages/sit-onyx/src/components/OnyxButton/OnyxButton.vue b/packages/sit-onyx/src/components/OnyxButton/OnyxButton.vue index 3dbce2883..43fdd0208 100644 --- a/packages/sit-onyx/src/components/OnyxButton/OnyxButton.vue +++ b/packages/sit-onyx/src/components/OnyxButton/OnyxButton.vue @@ -18,13 +18,6 @@ const props = withDefaults(defineProps(), { const { densityClass } = useDensity(props); -const emit = defineEmits<{ - /** - * Emitted when the button is clicked (and is not disabled). - */ - click: []; -}>(); - const rippleRef = ref>(); const rippleEvents = computed(() => rippleRef.value?.events ?? {}); @@ -44,7 +37,6 @@ const rippleEvents = computed(() => rippleRef.value?.events ?? {}); :type="props.type" :aria-label="props.loading ? props.label : undefined" :autofocus="props.autofocus" - @click="emit('click')" v-on="rippleEvents" > diff --git a/packages/sit-onyx/src/components/OnyxIconButton/OnyxIconButton.vue b/packages/sit-onyx/src/components/OnyxIconButton/OnyxIconButton.vue index ca95d65ee..07a05950d 100644 --- a/packages/sit-onyx/src/components/OnyxIconButton/OnyxIconButton.vue +++ b/packages/sit-onyx/src/components/OnyxIconButton/OnyxIconButton.vue @@ -18,11 +18,6 @@ defineSlots<{ /** Slot for an custom icon. Will have no effect if property `icon` is passed. */ default(): unknown; }>(); - -const emit = defineEmits<{ - /** Emitted when the button is clicked (and is not disabled). */ - click: []; -}>();