Deploying Selenium Grid with ArgoCD

[KyriosGN0]

we deploy selenium grid's helm chart with argoCD, we have been wondering about removing the helm hooks from the scaled jobs resources, has anyone done that? is it safe?
the main reasoning is that sometimes we want to make changes to those resources but argocd doesn't track them since they are deployed with helm hooks

[farioas]

I'm also using ArgoCD, so I've disabled the helm hooks, no problems at all:

autoscaling:
  patchObjectFinalizers:
    enabled: false # doesn't work with argocd
  annotations: ! # remove helm hooks
  authenticationRef:
    annotations: ! # remove helm hooks

[KyriosGN0]

when you are syncing the grid, do the running jobs get deleted ?

[farioas]

No, it was never the case. I'm using grid with argocd for more than 2 years.

[VietND96]

If you deploy the Selenium Grid chart using the existing KEDA, then helm hooks can be removed. Since the KEDA CDRDs are ready in the cluster to create the ScaledObject/ScaledJob resources in Grid chart.

[KyriosGN0]

@VietND96 what about the patch scaled job? should i disable it ?

[VietND96]

You can disable it also. Actually, that job is a workaround for deleting scaled job/object that might left over due to hooks or finalizers.