Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure and improve Seravo Plugin exception safety #536

Open
Moppa5 opened this issue Jun 10, 2021 · 1 comment
Open

Ensure and improve Seravo Plugin exception safety #536

Moppa5 opened this issue Jun 10, 2021 · 1 comment

Comments

@Moppa5
Copy link
Contributor

Moppa5 commented Jun 10, 2021

Description
Seravo Plugin has had many bugs related to assuming and blindly executing PHP code. For example, developing on local environment some fopen() etc. have caused many issues when the resource hasn't existed at all. As a part of the cleanup and Up-To-Date we should investigate carefully and ensure that Seravo Plugin handles these situations properly. Some parts can be checked with PHP return values and some with try catch statements.

This issue can include any PHP warnings & buggy code as well as they usually fall into the exception category.

@JoosuaKoskinen
Copy link
Contributor

I'm currently working on the new postbox system and one of the many new features is exception handling. If exception is thrown during the data fetch step of postbox rendering, user is shown proper error message and given instructions on opening an issue.

We should see if there's more we can do though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants