Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: "Invalid or ambiguous export entry 'a'" when loading shopify.com #22736

Open
awesomekling opened this issue Jan 13, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@awesomekling
Copy link
Contributor

This looks suspicious when loading https://shopify.com/

429235.259 WebContent(902277): Unhandled JavaScript exception (in promise): [SyntaxError] Invalid or ambiguous export entry 'a'
429235.259 WebContent(902277):     at <unknown>

We should investigate if this is something we're doing wrong.

@kleinesfilmroellchen kleinesfilmroellchen added the bug Something isn't working label Jan 19, 2024
@mobounya
Copy link
Contributor

mobounya commented Feb 13, 2024

the output now looks like this
89.392 WebContent(54): Unhandled JavaScript exception (in promise): [undefined] undefined

After some debugging and inspection it seems that there's an unhandled rejected promise in the shopify javascript code, I want to check the shopify JS source code manually to see for myself, however the code is a mess, so I was unable to do that.

Where should I go from here ? is this enough to mark this as a non-issue ?

@ADKaster
Copy link
Member

ADKaster commented Feb 14, 2024

When loading Shopify on Linux in the Qt chrome of Ladybird, I still see the log message referenced in the issue. I suspect that it's a code path not exercised with a Serenity user agent.

We also load cdn.shopify.com/favicon.ico like, 30 times. And then fail to decode it. That's also suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants