Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Theme Asset Upload Priority #4409

Closed
ceri-waterscreative opened this issue Sep 3, 2024 · 2 comments
Closed

[Feature]: Theme Asset Upload Priority #4409

ceri-waterscreative opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Type: Enhancement New feature or request

Comments

@ceri-waterscreative
Copy link

What area(s) will this request affect?

Theme

What type of change do you want to see?

New feature

Overview

Currently when running "shopify theme dev" the assets are uploaded in A-Z format, however if you have a lot of images in that folder (i.e. icons) it can take some time to actually upload. Instead I propose changing it to prioritise JS/CSS files first as they're more critical to the site and the developer can continue working while images are uploaded in the background.

Motivation

Impatiently waiting for themes with lots of icons to upload

@ceri-waterscreative ceri-waterscreative added the Type: Enhancement New feature or request label Sep 3, 2024
@lucyxiang lucyxiang added Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes labels Sep 3, 2024
@lucyxiang
Copy link
Contributor

Hello @ceri-waterscreative, thank you for raising this issue. We have a project in flight that will improve performance of asset uploads, thank you for your patience 🙏

@karreiro karreiro self-assigned this Sep 20, 2024
@karreiro
Copy link
Contributor

Thank you for reporting this issue, @ceri-waterscreative!

The new implementation of the shopify theme dev command (in the latest Shopify CLI release) no longer requires the synchronization phase to power the localhost preview and serves JS/CSS directly from the disk. With that in mind, I'm marking this issue as resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants