Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Should URLs with malformed skylinks return a 401 on Account-Only portals? #26

Open
dghelm opened this issue May 12, 2022 · 0 comments
Open
Assignees
Labels
invalid This doesn't seem right

Comments

@dghelm
Copy link

dghelm commented May 12, 2022

Describe the bug

Non-existent subdomains are interpreted as incorrectly formed skylinks, and on account-only portals, an error is returned about not being authenticated instead of the expected "your skylink is bunk".

To Reproduce

Visit https://asdfasdfsadfsadf.siasky.net/ and see "normal" behavior.
Visit https://asdfasdfsadfsadf.skynetfree.net/ and get asked to authenticate, even when logged in.

Expected behavior

Visiting the page should result in the user being informed their skylink is malformed. For not logged in users, either error will work.
Or, we build a better error page? Or not assume the user is trying to access a skylink when the data doesn't match one of our established server subdomains?

Screenshots

image

@dghelm dghelm added the invalid This doesn't seem right label May 12, 2022
@kwypchlo kwypchlo transferred this issue from SkynetLabs/skynet-webportal Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants