Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

NGINX Lua comments #3

Open
MSevey opened this issue Oct 26, 2021 · 1 comment
Open

NGINX Lua comments #3

MSevey opened this issue Oct 26, 2021 · 1 comment
Assignees

Comments

@MSevey
Copy link
Contributor

MSevey commented Oct 26, 2021

Can be a follow up, but does NGINX and lua allow for comments? Because if so we NEED to be adding them so that others can better understand what is happening here.

Reading this with no context makes me think you are setting the same skylink as the v1 and v2 skylink which intuitively doesn't make sense.

Originally posted by @MSevey in SkynetLabs/skynet-webportal#1223 (comment)

@MSevey
Copy link
Contributor Author

MSevey commented Oct 26, 2021

Are we overwriting the content type here or we're only setting it if it's not set? If we're overwriting it that might not be great.

Originally posted by @ro-tex in SkynetLabs/skynet-webportal#1223 (comment)

@MSevey MSevey changed the title Can be a follow up, but does NGINX and lua allow for comments? Because if so we NEED to be adding them so that others can better understand what is happening here. NGINX Lua comments Oct 26, 2021
@kwypchlo kwypchlo transferred this issue from SkynetLabs/skynet-webportal May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants