Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceleration decoding doesn't respect AXES_OFFSET #1006

Open
9il opened this issue Apr 24, 2024 · 5 comments · May be fixed by #1014
Open

Acceleration decoding doesn't respect AXES_OFFSET #1006

9il opened this issue Apr 24, 2024 · 5 comments · May be fixed by #1014
Labels
Area: Hardware Protocol Related to communication with hardware/software trackers Area: Server Related to the server Type: Bug Something isn't working

Comments

@9il
Copy link
Contributor

9il commented Apr 24, 2024 •
edited
Loading

SlimeVR do convert rotation from tracker to openGL axis, but forget to do so for acceleration vector.
@Erimelowo
Copy link
Member

It does:

SlimeVR-Server/server/core/src/main/java/dev/slimevr/tracking/trackers/udp/TrackersUDPServer.kt

Line 357 in 24f2895

// Switch x and y around to adjust for different axes

@9il
Copy link
Contributor Author

9il commented Apr 24, 2024 •
edited
Loading

AXES_OFFSET transformation is a quaternion transformation; it can't be a reflection transformation. It changes Y and Z with a single sign change.

It does:

It is reflection transformation (conversion between left-hand and right-hand axis).

So, it can't be the same transformation.

@9il
Copy link
Contributor Author

9il commented Apr 24, 2024

@Louka3000 What is the tracker axis in the UDP packet?

  • Z up or Y up?
  • Is it right-handed or left-handed?

@9il 9il mentioned this issue Apr 24, 2024
Merged
@Erimelowo
Copy link
Member

I believe SlimeVR expects Y+ forward, X+ right, Z+ up, but not entirely sure right now
OpenVR is Z- Forward, X+ Right, Y+ Up

@9il
Copy link
Contributor Author

9il commented Apr 24, 2024

Understood. We're currently dealing with the Z+ up vs. Y+ Up and hand switch issue.

However,

SlimeVR-Server/server/core/src/main/java/dev/slimevr/tracking/trackers/udp/TrackersUDPServer.kt

doesn't affect Z at all.

@9il 9il linked a pull request Apr 29, 2024 that will close this issue
Open
@ImUrX ImUrX added Type: Bug Something isn't working Area: Hardware Protocol Related to communication with hardware/software trackers Area: Server Related to the server labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Hardware Protocol Related to communication with hardware/software trackers Area: Server Related to the server Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix acceleration axis and leg tweaks gestures-space/SlimeVR-Server
3 participants
@9il @ImUrX @Erimelowo