Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint is Python not socketcli for Docker Hub Image #292

Closed
joswr1ght opened this issue Jan 16, 2025 · 2 comments
Closed

Entrypoint is Python not socketcli for Docker Hub Image #292

joswr1ght opened this issue Jan 16, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@joswr1ght
Copy link

I'm not sure if this is the right repo to report this, but I was surprised when I ran the socketdev/cli container from Docker Hub and got a Python prompt:

~ % docker run --rm -it socketdev/cli    
Unable to find image 'socketdev/cli:latest' locally
latest: Pulling from socketdev/cli
c5a4543f1ca2: Download complete 
6d93ed64a567: Download complete 
00bf490d8a42: Download complete 
169b11b45c54: Download complete 
ae1381227ad3: Download complete 
Digest: sha256:8c058d3b200f1f15e571668be882dd896a27647145522e587bf1c8bfd412a24a
Status: Downloaded newer image for socketdev/cli:latest
Python 3.13.0 (main, Oct 19 2024, 02:39:03) [GCC 13.2.1 20240309] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 

I expected something more along the lines of this:

socketcli % cat Dockerfile
FROM socketdev/cli:latest
ENTRYPOINT ["socketcli"]
socketcli % docker build -t socketcli .
...
socketcli % docker run --rm -it socketcli --help
usage: socketcli [-h] [--api_token API_TOKEN] [--repo REPO] [--branch BRANCH] [--committer COMMITTER]
                 [--pr_number PR_NUMBER] [--commit_message COMMIT_MESSAGE] [--default_branch]
                 [--target_path TARGET_PATH] [--scm {api,github,gitlab}] [--sbom-file SBOM_FILE]
                 [--commit-sha COMMIT_SHA] [--generate-license GENERATE_LICENSE] [-v] [--enable-debug]
                 [--allow-unverified] [--enable-json] [--disable-overview] [--disable-security-issue] [--files FILES]
                 [--ignore-commit-files] [--disable-blocking]

Socket Security CLI
...

Is the Docker Hub container for socketdev/cli not expedcted to be used to run socketcli from the command line?

@dacoburn
Copy link
Contributor

@joswr1ght The one used in the container (https://github.com/SocketDev/socket-python-cli) had been originally created for using with the Gitlab Pipeline which when run in the runner boots into a shell ignoring the entrypoint. We can definitely add it in.

@jdalton
Copy link
Collaborator

jdalton commented Jan 16, 2025

Moved to SocketDev/socket-python-cli#37.

@jdalton jdalton added bug Something isn't working and removed enhancement New feature or request labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants