Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexObjects compatibility: change references to Page class to use PageInterface #30

Open
paulhibbitts opened this issue Sep 20, 2019 · 1 comment

Comments

@paulhibbitts
Copy link

paulhibbitts commented Sep 20, 2019

Hi @Sommerregen ,

I have started to use the newest Grav 1.7 Beta with Flex Objects, and have discovered a compatibility issue with External Links:
trilbymedia/grav-plugin-flex-objects#16

It looks like the fix for this is fairly minor issue to address (as Andy Miller just did for ShortCodes):
getgrav/grav-plugin-shortcode-core@c374d81

Might you please consider making this change in External Links? I'd be happy to test for you etc. This would then let all early users of Flex Pages use your Plugin🙂

Thanks very much,
Paul

@mahagr
Copy link

mahagr commented Sep 20, 2019

Also, make sure the minimum Grav version is >=1.6 inside the blueprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants