Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design & functionality proposal #6

Open
jwillmer opened this issue Mar 3, 2017 · 4 comments
Open

Design & functionality proposal #6

jwillmer opened this issue Mar 3, 2017 · 4 comments

Comments

@jwillmer
Copy link

jwillmer commented Mar 3, 2017

I found a very nice looking upload webcomponent on GitHub. Maybe fork/merge/contribute it and extend the functionality to upload files over WebSocket?

@warpech
Copy link
Contributor

warpech commented Mar 3, 2017

If it is only about the looks then it might be easier to redesign the looks of starcounter-upload

@warpech
Copy link
Contributor

warpech commented Mar 3, 2017

But I agree this one looks more mature, with nice configuration options, etc.

@jwillmer
Copy link
Author

jwillmer commented Mar 3, 2017

My idea is that contributing to the control would give Starcounter a nice looking control with a lot of features and outsources the maintenance.

@warpech
Copy link
Contributor

warpech commented Mar 7, 2017

I think they will not agree, because there is no standard for uploading via WebSocket.

Dissecting starcounter-upload into two pieces is a nice alternative. Piece 1 reads the file from disk into an array buffer (might be using https://www.webcomponents.org/element/LostInBrittany/granite-file-reader/granite-file-reader), piece 2 uploads the array buffer over WebSocket.

@warpech warpech added this to the Juicy elements support milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants