Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition is always false #8

Open
mmnosek opened this issue May 16, 2017 · 1 comment
Open

Condition is always false #8

mmnosek opened this issue May 16, 2017 · 1 comment

Comments

@mmnosek
Copy link

mmnosek commented May 16, 2017

Steps to reproduce

  1. Run Starcounter Images app (latest develop)
  2. Go to `localhost:8080/Images
  3. Try to upload new image

Expected result

Image is uploaded successfully and websocket is closed

Actual result

Image is uploaded successfully (almost always) but websocket is never closed

Screenshot

images_and_windows_10

I've tried to debug and found one issue, but I'm not sure if it will help:
This condition: https://github.com/Starcounter/starcounter-upload/blob/master/starcounter-upload.html#L224 is always false. The reason is that evt.data is a string, not a JSON object. evt.data should be parsed first.

Even without it onclose is always called, so I'm not sure if it will help with this issue.

cc @miyconst @warpech

@mmnosek mmnosek changed the title Websocket connection is never closed Condition is always false May 16, 2017
@mmnosek
Copy link
Author

mmnosek commented May 16, 2017

Update: It is closed, but the condition in l224 is never true. should be removed or rewritten.

@warpech warpech added this to the Juicy elements support milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants