Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup duplication in api.js #41

Open
oliversalzburg opened this issue Jun 4, 2015 · 1 comment
Open

Cleanup duplication in api.js #41

oliversalzburg opened this issue Jun 4, 2015 · 1 comment
Labels
refactor

Comments

@oliversalzburg
Copy link
Member

The only reference to the file is in a test. It's not used in this plugin and I can't find another plugin that references it.

In fact, there is a lot of code duplication between api.js and index.js.
@oliversalzburg
Copy link
Member Author

Ah, now I see the usages. I was grep'ing for api.js and didn't find the imports.

However, my point about the code duplication remains. Is there a reason for this?

@knownasilya knownasilya changed the title What is the point of api.js? Cleanup duplication in api.js Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knownasilya @oliversalzburg