-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NODE_ENV leaks into test run #21
Comments
Yeah, we should only whitelist certain variables: $HOME, $PATH, $PAAS_NAME |
do we need $HOME? tests really shouldn't be messing with it ... although On Tue, Aug 20, 2013 at 10:43 AM, niallo [email protected] wrote:
|
Many UNIX utilities expect $HOME to be available. NPM for example writes to $HOME/.npm |
what if we make $HOME be the tmp directory where we're running the build? On Tue, Aug 20, 2013 at 12:31 PM, niallo [email protected] wrote:
|
Seems to me that the expectation is HOME is whatever the shell sets. But as long as the location is writable I guess it's ok. POSIX says (section 2.5.3): http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html |
Yeah, I'm not married to either direction. On Tue, Aug 20, 2013 at 2:31 PM, niallo [email protected] wrote:
|
If you run strider with NODE_ENV=prod,
npm install
doesn't install dev modules.Should we just block out the parent env entirely when running child processes? (with perhaps the exception of PATH)
https://github.com/Strider-CD/strider-simple-worker/blob/master/lib/job.js#L120
The text was updated successfully, but these errors were encountered: