Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM for more performant backend images #429

Conversation

Harsh3305
Copy link

@Harsh3305 Harsh3305 commented Oct 4, 2023

close #422

@Harsh3305 Harsh3305 marked this pull request as ready for review October 4, 2023 14:36
@Harsh3305
Copy link
Author

Hi @SponsoredByPuma 👋🏻
Can you review my PR.
Thanks

@SponsoredByPuma
Copy link
Contributor

Yeah, sure I will look into this the next following days

@SponsoredByPuma
Copy link
Contributor

Hi @Harsh3305,
I looked over your PR and it looks good.
I've just got a problem trying to run it on my machine, maybe you could help me out there.
Everytime i try to run it I get this error:
image
What could I do to fix this?

@Dan1elBox
Copy link
Collaborator

I receive the same error as @SponsoredByPuma .
Could this possibly be due to all GraalVM images now being on GHCR?

See: https://github.com/graalvm/container/pkgs/container/graalvm-ce
We might need to change oracle/graalvm-ce:latest to, for example, ghcr.io/graalvm/graalvm-ce:ol8-java17.

@Harsh3305
Copy link
Author

Hi @SponsoredByPuma @Dan1elBox
Done some changes in dockerfile. Please review 😄

@SponsoredByPuma
Copy link
Contributor

Hi @Harsh3305,
the issue is now fixed. Currently I get an error message at the last step:
image
Which command are you using to start the docker?

@Dan1elBox
Copy link
Collaborator

Hi @Harsh3305
The image now loads correctly, but I'm encountering the same error as @SponsoredByPuma, indicating that I should specify the class with the main entry point method.

@KzuDemEvin
Copy link
Collaborator

Hi @Harsh3305,
is there any performance gain at all with GraalVM over Docker?

@stritti
Copy link
Member

stritti commented Oct 25, 2023

Hi @Harsh3305,

is there any performance gain at all with GraalVM over Docker?

@KzuDemEvin GraalVM is created especially for container environments and requires less space and startup overhead - as I know.

@stritti
Copy link
Member

stritti commented Oct 30, 2023

I think this needs more investigation than just replace docker: https://docs.spring.io/spring-boot/docs/current/reference/html/native-image.html

@Dan1elBox
Copy link
Collaborator

Hi @Harsh3305, thank you for your interest and contribution to this project 😃
Do you plan to continue working on this PR in the future?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM for more performant backend images
5 participants