Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of AnalyticsComponent #487

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

123noahB
Copy link

Changed the styling similar to the boxes above.

# Conflicts:
#	frontend/src/components/AnalyticsDataComponent.vue
@Dan1elBox Dan1elBox linked an issue Oct 26, 2023 that may be closed by this pull request
@Dan1elBox
Copy link
Collaborator

Dan1elBox commented Oct 26, 2023

Hey @123noahB , looks really good 👍. Thanks for your contribution. While we're at it, what do you think about moving all the inline styles for the text alignments into a separate class and then applying that class to all the b-card-text sub-components? 😃
Also you could just simply add text-align: center; to our .statsCards {...} and remove all text alignment inline styles.
This would make it even easier to modify and maintain the appearance of the page in the future.

@123noahB
Copy link
Author

Hey @Dan1elBox , i moved the text-align into stats-cards. I tried to change the rest but it didn't work, either the line or tilte moved. I hope it's ok like it is now.

@stritti
Copy link
Member

stritti commented Oct 30, 2023

@123noahB could you fix the lint errors please: https://github.com/Sybit-Education/Diveni/actions/runs/6689791281/job/18183010772?pr=487

Could be done by running npm run lint:fix locally at frontend directory.

{{ $t("page.landing.meeting.analytics.activeTitle") }}
</b-card-title>
<div class="line"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just <hr />?

{{ $t("page.landing.meeting.analytics.lastMonthTitle") }}
</b-card-title>
<div class="line"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just


?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling of AnalyticsComponent
4 participants