-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling of AnalyticsComponent #487
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # frontend/src/components/AnalyticsDataComponent.vue
Hey @123noahB , looks really good 👍. Thanks for your contribution. While we're at it, what do you think about moving all the inline styles for the text alignments into a separate class and then applying that class to all the b-card-text sub-components? 😃 |
Hey @Dan1elBox , i moved the text-align into stats-cards. I tried to change the rest but it didn't work, either the line or tilte moved. I hope it's ok like it is now. |
@123noahB could you fix the lint errors please: https://github.com/Sybit-Education/Diveni/actions/runs/6689791281/job/18183010772?pr=487 Could be done by running |
{{ $t("page.landing.meeting.analytics.activeTitle") }} | ||
</b-card-title> | ||
<div class="line"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just <hr />
?
{{ $t("page.landing.meeting.analytics.lastMonthTitle") }} | ||
</b-card-title> | ||
<div class="line"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
?
Changed the styling similar to the boxes above.