Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAREXT is broken? #11

Closed
pha377 opened this issue Jul 14, 2023 · 1 comment
Closed

SAREXT is broken? #11

pha377 opened this issue Jul 14, 2023 · 1 comment

Comments

@pha377
Copy link

pha377 commented Jul 14, 2023

at line 372 of ta_SAREXT.c:

/* This function is the same as TA_SAR, except that the caller has

  • greater control on the SAR dynamic and initial state.
  • In additon, the TA_SAREXT returns negative values when the position
  • is short. This allow to distinguish when the SAR do actually reverse.
    */

So, the first part implies that I can use SAREXT and with some parameters I would get the same results as TA_SAR

But, in the second part it say that no, it will not be the case

Shouldn't the function be fixed?

@mario4tier
Copy link
Member

TA_SAREXT is not intended to be a compatible replacement to TA_SAR.

TA_SAREXT is same as TA_SAR except for the major differences enumerated.

except and in addition are the keywords.

If anything need to be fix, it would be the wording of the comment 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants