-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Android distribution #287
Comments
upleveling androidkeymanager is a dupe of an existing ticket #250 |
Ah thanks @jiyoontbd - updating ticket description |
OK, I've done some research and there's 2 approaches we can take here:
Because of alignment with the greater Android ecosystem, I propose we go with 2. This comes at the expense of when we make a Project leads, what say you? cc: @jiyoontbd @mistermoe @michaelneale @leordev |
@ALRubinger what are the downsides of including a |
@mistermoe I'd hoped to do that, but: The Gradle build would then be triggered by the Maven build, and the two are not the same. So the Gradle build for Android would not be picking up the components built by the Maven main build. For example:
Unless you're seeing a solution for this I'm missing? |
ah because we need to reference the version bumped |
@mistermoe Yes. |
cc @nitro-neal as he's onboarding as kotlin dri what you recommend (option 2) sounds reasonable to me @ALRubinger ! |
re: what we did with awskeymanager #327 - would option 2 mean we take the same approach for androidkeymanager? |
@ALRubinger @nitro-neal @jiyoontbd Good topic to discuss in the context of the Rust Core initiative and our priorities for the Kotlin SDKs for the next month. |
Structurally different; Option 2 proposes another repo depending on |
perhaps one short term thing is to document how to do a key manager in android and let people copy/paste inline to their code if simple enough? (longer term - yeah kotlin SDK priorities) |
With With leads advising their preferred direction for this I can get the work done. |
@michaelneale has been trailblazing to validate
tbdex-kt
(and by extension,web5-kt
), for Android apps in https://github.com/TBD54566975/tbdex-android-example.This uncovers a few things we can do to make these libraries more consumable by Android devs:
AndroidKeyManager
intoweb5-kt
(see dep Migrate AndroidKeyManager to web5-kt #250 below)Dependencies of this issue:
To preflight this approach with @jiyoontbd to her +1 before cracking work.
The text was updated successfully, but these errors were encountered: