You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #322 we broke out the AwsKeyManager implementation and its test suite into its own module, web5-keymanager-aws.
This breaks the build in that new module, inheriting the coverage plugin's enforcement. Because all existing tests are marked as @Disabled, there is no coverage for the module.
To unlock the work in #322, we elected to move forward by disabling the kover-maven-plugin enforcement constraint, opting to enable the tests and re-add coverage enforcement later. That discussion is In PR #327.
Remove the configuration that skips coverage enforcement in the web5-keymanager-awspom.xml (ie. commit 1eb180c:
<plugin>
<groupId>io.github.martinvisser</groupId>
<artifactId>kover-maven-plugin</artifactId>
<configuration>
<!-- We temporarily disable coverage enforcement until we have tests working for this module -->
<skip>true</skip>
</configuration>
</plugin>
The text was updated successfully, but these errors were encountered:
ALRubinger
changed the title
Enable tests for AwkKeyManager and remove skip on keymanager-awskover-maven-plugin config
Enable tests for AwsKeyManager and remove skip on keymanager-awskover-maven-plugin config
Jun 27, 2024
In #322 we broke out the
AwsKeyManager
implementation and its test suite into its own module,web5-keymanager-aws
.This breaks the build in that new module, inheriting the coverage plugin's enforcement. Because all existing tests are marked as
@Disabled
, there is no coverage for the module.To unlock the work in #322, we elected to move forward by disabling the
kover-maven-plugin
enforcement constraint, opting to enable the tests and re-add coverage enforcement later. That discussion is In PR #327.This issue is the "later" cleanup task. :)
web5-keymanager-aws
pom.xml
(ie. commit 1eb180c:The text was updated successfully, but these errors were encountered: