Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Histogram module for calculation & Equalization #117

Open
akarsh opened this issue Oct 10, 2015 · 2 comments
Open

Create Histogram module for calculation & Equalization #117

akarsh opened this issue Oct 10, 2015 · 2 comments

Comments

@akarsh
Copy link
Contributor

akarsh commented Oct 10, 2015

I had created the Histogram Calculation, and, Histogram Equalization with the reference to the documentation from OpenCV

http://docs.opencv.org/doc/tutorials/imgproc/histograms/histogram_equalization/histogram_equalization.html

http://docs.opencv.org/doc/tutorials/imgproc/histograms/histogram_calculation/histogram_calculation.html

Made changes to calculate the histogram for grayscale images, as it was not present in the open cv documentation.

Request for code review

here are the files

https://github.com/akarsh/uipf/blame/akarsh-patch-2/code/modules/improc/CalculateHistModule.cpp

https://github.com/akarsh/uipf/blame/akarsh-patch-2/code/modules/improc/HistogramEqualizationModule.cpp

@cebe
Copy link
Member

cebe commented Oct 11, 2015

Request for code review

for code review, please send a pull request from that branch (use a new branch for each pull request). Using pull request it is easier to review and one can directly comment on the code lines.

@akarsh
Copy link
Contributor Author

akarsh commented Oct 11, 2015

I made one pull request, NO one commented on it.
So, i did not make further.
Here is the new one with only branch with the files.
#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants