From d74e31e04d92d7b0d81830f7cdb67d66b89430c5 Mon Sep 17 00:00:00 2001 From: leMaik Date: Wed, 21 Sep 2016 12:22:01 +0200 Subject: [PATCH] Fix react warnings and Dots stories. --- src/AutoRotatingCarousel.js | 7 ++++--- src/SwipableCarouselView.js | 10 ++++++++-- stories/AutoRotatingDots.js | 2 +- stories/index.js | 2 +- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/AutoRotatingCarousel.js b/src/AutoRotatingCarousel.js index 5be0a86..9b99b37 100644 --- a/src/AutoRotatingCarousel.js +++ b/src/AutoRotatingCarousel.js @@ -142,7 +142,7 @@ export class AutoRotatingCarousel extends Component { {this.props.open ?
this.handleChange(value)} slideStyle={style.slide} > - {this.props.children.map((c) => React.cloneElement(c, { + {this.props.children.map((c, i) => React.cloneElement(c, { mobile: this.props.mobile, - landscape: this.props.landscape + landscape: this.props.landscape, + key: i }))} diff --git a/src/SwipableCarouselView.js b/src/SwipableCarouselView.js index 2c6109f..7c4426c 100644 --- a/src/SwipableCarouselView.js +++ b/src/SwipableCarouselView.js @@ -1,4 +1,4 @@ -import React from 'react' +import React, { PropTypes } from 'react' import autoPlay from 'react-swipeable-views/lib/autoPlay' import virtualize from 'react-swipeable-views/lib/virtualize' import SwipeableViews from 'react-swipeable-views' @@ -15,4 +15,10 @@ export default function Carousel ({ children, ...other }) { ) } -Carousel.propTypes = VirtualizeAutoPlaySwipeViews.propTypes +if (process.env.NODE_ENV !== 'production') { + Carousel.propTypes = { + ...VirtualizeAutoPlaySwipeViews.propTypes, + children: PropTypes.node + } + delete Carousel.propTypes.slideRenderer +} diff --git a/stories/AutoRotatingDots.js b/stories/AutoRotatingDots.js index 95ec697..b10f4e2 100644 --- a/stories/AutoRotatingDots.js +++ b/stories/AutoRotatingDots.js @@ -1,5 +1,5 @@ import React from 'react' -import { Dots } from '../src/Dots' +import Dots from '../src/Dots' export default class extends React.Component { constructor (props) { diff --git a/stories/index.js b/stories/index.js index fc6d7aa..2e0d6ce 100644 --- a/stories/index.js +++ b/stories/index.js @@ -2,7 +2,7 @@ import React from 'react' import { storiesOf, action, linkTo } from '@kadira/storybook' import { green400, green600, blue400, blue600, red400, red600 } from 'material-ui/styles/colors' import { AutoRotatingCarousel, Slide } from '../src' -import { Dots } from '../src/Dots' +import Dots from '../src/Dots' import { themed } from './storyUtil' import AutoRotatingDots from './AutoRotatingDots'