Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing empty values #8

Open
kyle-rader-msft opened this issue Mar 1, 2024 · 3 comments
Open

Allowing empty values #8

kyle-rader-msft opened this issue Mar 1, 2024 · 3 comments

Comments

@kyle-rader-msft
Copy link
Contributor

It turns out that in many config files within a project of ours, empty values are normal and do not cause issues with our IDE's so we'd like our linter to mirror this if possible.

Proposal

Enable empty values to be parsed as empty lines or pairs behind a feature flag so callers can decide what level of enforcement they get.
@kyle-rader-msft kyle-rader-msft mentioned this issue Mar 1, 2024
Merged
TheDaemoness pushed a commit that referenced this issue Mar 7, 2024
@kyle-rader-msft
Create feature flag allow-empty-values (#7)
ca62ab4 
This PR address #8, introducing our first feature flag to allow for
parsing lines that have a key but no value.

We also enable running the tests with all features enabled as well as
the default.

Signed-off-by: Kyle Rader <[email protected]>
Co-authored-by: Kyle Rader <[email protected]>
@TheDaemoness
Copy link
Owner

Implemented as proposed in #7. Thank you!

@TheDaemoness
Copy link
Owner

Reopening because it looks like the spec is likely to explicitly allow empty values in the future. The ideal way forward IMO involves some breaking changes to Properties, but I'd like to get a minor release out soon instead of waiting for that PR to resolve.

@TheDaemoness TheDaemoness reopened this Mar 8, 2024
@kyle-rader-msft
Copy link
Contributor Author

Ah well look at that. Sounds good. The feature flag could be removed then as well when updating it to be the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheDaemoness @kyle-rader-msft