Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket not propagating close event #674

Closed
victormartinsantiago opened this issue Oct 29, 2018 · 2 comments
Closed

Websocket not propagating close event #674

victormartinsantiago opened this issue Oct 29, 2018 · 2 comments
Labels
bug Identified as a potential bug Websockets Ocelot feature: Websockets

Comments

@victormartinsantiago
Copy link

Expected Behavior / New Feature

When a socket is closed between ocelot and the destination service, the onclose event is not propagated from Ocelot to the client, so the client is never aware that the socket is no longer usable

Actual Behavior / Motivation for New Feature

When the onclose event happens in Ocelot, the respective socket between Ocelot and the client should be closed as well so the client can try an reconnect again. This is relevant when both the gateway and the destination services are running as a containers and they are subjet to random restarts.

Steps to Reproduce the Problem

  1. Open a ws connection to an aspnet core service thru Ocelot running on aspnet core service
  2. Bring the destination service down so the onclosed event is fired
  3. The onclose event shall happen in Ocelot but is never progapaged to the caller (client)

Specifications

  • Version: 8.0.2
  • Platform: ASPNET Core 2.1.0.4
  • Subsystem:
@philproctor philproctor added bug Identified as a potential bug needs validation Issue has not been replicated or verified yet labels Jan 10, 2019
@tdejong-tools4ever
Copy link
Contributor

When trying to use ocelot to proxy between my service and client I have also encountered the issue of the connection not closing properly after the service shuts down. This, however, seems to be an issue in the WampSharp library as it does not send a proper WebSocket closed event.

I do however assume that when the service WebSocket gives an exception with error ConnectionClosedPrematurely something would be wrong with the service and a new connection should be agreed upon. I assume the simplest fix would be to return a closed connection message (although I do not know exactly what issues this could possibly create).

@raman-m raman-m added Websockets Ocelot feature: Websockets and removed needs validation Issue has not been replicated or verified yet labels Jun 15, 2024
@raman-m
Copy link
Member

raman-m commented Jun 15, 2024

Too outdated issue.
Will be checked as a part of #1040

@raman-m raman-m closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identified as a potential bug Websockets Ocelot feature: Websockets
Projects
None yet
Development

No branches or pull requests

4 participants