Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngCookies - Cookie Methods Different for Angular 1.4 + #22

Open
mmansour opened this issue Apr 7, 2016 · 2 comments
Open

ngCookies - Cookie Methods Different for Angular 1.4 + #22

mmansour opened this issue Apr 7, 2016 · 2 comments

Comments

@mmansour
Copy link

mmansour commented Apr 7, 2016

Hi -

Thanks for open sourcing this time saver.

I noticed the cookie methods in djangoAuth.js need to be updated for later versions of angular

delete $cookies.token;
changes to:
$cookies.remove('token');

$cookies.token
changes to:
$cookies.get('token')

$cookies.token = data.key;
changes to:
$cookies.put("token", data.key);

Not sure if the this project is still active but thought I'd make a note here if someone wants to try this with a newer version of angular.

@adimux
Copy link

adimux commented Apr 7, 2016

You're right. I've already proposed that.
Can someone update the code ?

@molecular
Copy link

molecular commented May 2, 2016

+1 had same problem. Can't easily make PR because of other code changes intermingled and didn't fork ;|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants