Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All client side errors should have the NativeLink version attached to it #1044

Open
allada opened this issue Jun 22, 2024 · 3 comments
Open
Labels
good first issue Good for newcomers

Comments

@allada
Copy link
Member

allada commented Jun 22, 2024

To make it easier to understand what version people are using when there's a problem, we should attach a hash that represents what version or commit of NL they are using.

cc: @aaronmondal for how we might be able to stamp this by default but not invalidate cache?

@allada allada added the good first issue Good for newcomers label Jun 22, 2024
@ibilalkayy
Copy link
Contributor

I would like to work on this issue but I didn't understand the client side details of it

@aleksdmladenovic
Copy link
Contributor

I'm gonna work on this issue. cc: @allada. @MarcusSorealheis

@MarcusSorealheis
Copy link
Collaborator

We will review any PRs and we appreciate the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants