-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support digest_function in GrpcStore #1325
Comments
If you are looking to solve this issue, look into resource_info.rs. It predates our support |
I will work on this issue. cc: @MarcusSorealheis, @allada, @bclark8923. |
Hi, @bclark8923. I looked over details of this issue and I have some things unclear about this issue. FYI, from this PR, we now detect digest function automatically from the request. And there is code for nativelink/nativelink-store/src/grpc_store.rs Lines 438 to 442 in 8d957a5
nativelink/nativelink-store/src/grpc_store.rs Lines 494 to 498 in 8d957a5
nativelink/nativelink-store/src/grpc_store.rs Lines 541 to 545 in 8d957a5
And just fyi, while I was trying to evaluate this issue, I found out that there were no Did we omit this for specific purpose or just missing and need to be added later? And I hope you to make it clear how you caught this issue and how you tested. Thanks. cc: @allada, @MarcusSorealheis |
When using an alternative hash function to the default (sha256), GRPC store doesn't receive which hash function to use.
The text was updated successfully, but these errors were encountered: