Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness issues in lre-cc when used as backing toolchain for lre-rs in cross compilation scenarios #1595

Open
aaronmondal opened this issue Feb 21, 2025 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@aaronmondal
Copy link
Member

It's a known issue that the current implementation of lre-cc doesn't support cross compilation. This was ok for most usecases since it still worked in host == exec scenarios.

Now, upstream nix has marked our practice of using the wrapped clang (customClang) as faulty because the rust context is a cross compilation context but customClang in it's current state is not a cross compiler (NixOS/nixpkgs#323869). That is, the fact that our current implementation works should be treated as "working by chance".

To fix this we need to construct the LRE cc_toolchain properly as a cross compilation toolchain. This will also unlock arbitrary crosscompilation for C++ and Rust.

@aaronmondal aaronmondal added bug Something isn't working enhancement New feature or request labels Feb 21, 2025
@aaronmondal aaronmondal self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant