Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MacroTools #92

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Remove MacroTools #92

merged 7 commits into from
Apr 2, 2024

Conversation

yebai
Copy link
Member

@yebai yebai commented Mar 31, 2024

@yebai yebai changed the title Update varname.jl Remove MacroTools Mar 31, 2024
@yebai yebai requested a review from sunxd3 March 31, 2024 16:41
@yebai
Copy link
Member Author

yebai commented Mar 31, 2024

The following lines require MacroTools.capture. Can these lines be rewritten to avoid the dependency on MacroTools? If such a rewrite requires a substantial effort, we can add MacroTools as a dependency.

if @capture(ex, (opticsexprs__))

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (b342b3d) to head (76ace06).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   84.82%   88.20%   +3.37%     
==========================================
  Files           3        3              
  Lines         145      178      +33     
==========================================
+ Hits          123      157      +34     
+ Misses         22       21       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunxd3
Copy link
Member

sunxd3 commented Mar 31, 2024

Yep, Accessors depends on MacroTools, we can just use it as a bridge.

src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Show resolved Hide resolved
@yebai yebai requested a review from torfjelde March 31, 2024 18:15
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
src/varname.jl Outdated Show resolved Hide resolved
test/varname.jl Outdated Show resolved Hide resolved
@sunxd3
Copy link
Member

sunxd3 commented Apr 1, 2024

All good suggestions, thanks @devmotion!

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some clarification regarding the change from @sunxd3 here, but otherwise looks good. So will approve if it turns out to be nothing:)

src/varname.jl Show resolved Hide resolved
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sunxd3 :)

@sunxd3 sunxd3 merged commit cc9c8ed into main Apr 2, 2024
12 checks passed
@sunxd3 sunxd3 deleted the remove-macrotools branch April 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants