-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MacroTools #92
Conversation
The following lines require Line 692 in f3fbce0
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 84.82% 88.20% +3.37%
==========================================
Files 3 3
Lines 145 178 +33
==========================================
+ Hits 123 157 +34
+ Misses 22 21 -1 ☔ View full report in Codecov by Sentry. |
Yep, |
Co-authored-by: David Widmann <[email protected]>
All good suggestions, thanks @devmotion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some clarification regarding the change from @sunxd3 here, but otherwise looks good. So will approve if it turns out to be nothing:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @sunxd3 :)
Related: JuliaRegistries/General#103811 (comment)