Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between the Universal Router technical reference and the Commands.sol library #895

Open
igorroncevic opened this issue Feb 13, 2025 · 1 comment

Comments

@igorroncevic
Copy link

I've noticed that there is a large discrepancy between the commands that are noted down in the Universal Router technical docs and the Commands.sol library in the uniswap/universal-router repo.

Notably, V4_SWAP is not even mentioned, which is a big deal given the fact that it has actions encoded within it, so detailed guide on what those do would be useful to have in the Technical Reference page.

@cqlyj
Copy link

cqlyj commented Feb 18, 2025

I've faced the same issue and resolved it by specifying the latest commit hash when installing the dependency. You can try installing it like this if you are using foundry:

forge install uniswap/universal-router@8bd498a --no-commit

And if you also facing issues like incorrect import paths, my solution is install the v2 and v3 core contracts as below:

forge install uniswap/v2-core --no-commit 
forge install uniswap/v3-core --no-commit

And update the remapping for them.

This ensures you're using a version that includes V4_SWAP.
However, I agree that the documentation should be updated to reflect this command properly, especially given its importance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants