From 84976af651cd2b75f2e734fce32a063ec7e0a492 Mon Sep 17 00:00:00 2001 From: "i.mirdzhamolov" Date: Wed, 11 May 2022 15:57:56 +0300 Subject: [PATCH 1/3] fix(FixedLayout): correct centering --- src/components/FixedLayout/FixedLayout.css | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/components/FixedLayout/FixedLayout.css b/src/components/FixedLayout/FixedLayout.css index 604ed765a4..c9175dd662 100644 --- a/src/components/FixedLayout/FixedLayout.css +++ b/src/components/FixedLayout/FixedLayout.css @@ -1,8 +1,11 @@ .FixedLayout { position: fixed; box-sizing: border-box; - left: auto; + left: 0; + right: 0; z-index: 3; + margin-left: auto; + margin-right: auto; padding-left: var(--safe-area-inset-left); padding-right: var(--safe-area-inset-right); } @@ -14,12 +17,10 @@ .FixedLayout--top { width: 100%; top: 0; - left: 0; } .FixedLayout--bottom { width: 100%; - left: 0; bottom: 0; padding-bottom: var(--safe-area-inset-bottom); } From 82f34ccd832a2055e24ddeafac5cde622b6cb8ed Mon Sep 17 00:00:00 2001 From: "i.mirdzhamolov" Date: Thu, 12 May 2022 20:56:36 +0300 Subject: [PATCH 2/3] fix(FixedLayout): revert to 1364 PR number MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Исправление сломало `SplitLayout`, в котором в текущей версии важно, чтобы у `FixedLayout` было `left: auto` --- src/components/FixedLayout/FixedLayout.css | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/components/FixedLayout/FixedLayout.css b/src/components/FixedLayout/FixedLayout.css index c9175dd662..31a251d15e 100644 --- a/src/components/FixedLayout/FixedLayout.css +++ b/src/components/FixedLayout/FixedLayout.css @@ -1,11 +1,8 @@ .FixedLayout { position: fixed; box-sizing: border-box; - left: 0; - right: 0; + left: auto; z-index: 3; - margin-left: auto; - margin-right: auto; padding-left: var(--safe-area-inset-left); padding-right: var(--safe-area-inset-right); } From 6ef1bab97d7ae09a5f80bf163d62b6395b9355fe Mon Sep 17 00:00:00 2001 From: "i.mirdzhamolov" Date: Fri, 13 May 2022 09:12:58 +0300 Subject: [PATCH 3/3] feat(FixedLayout): add comment for `left: auto` --- src/components/FixedLayout/FixedLayout.css | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/components/FixedLayout/FixedLayout.css b/src/components/FixedLayout/FixedLayout.css index 31a251d15e..b9e82e99a2 100644 --- a/src/components/FixedLayout/FixedLayout.css +++ b/src/components/FixedLayout/FixedLayout.css @@ -1,6 +1,16 @@ .FixedLayout { position: fixed; box-sizing: border-box; + /** + * ⚠️ WARNING ⚠️ + * `left: auto` решает следующие задачи: + * 1. При фиксированной ширине компонента позиционирует компонент по центру. + * 2. При использовании `SplitLayout` позиционирует компонент с права от ``. + * + * Подробности можно почитать здесь https://github.com/VKCOM/VKUI/pull/2472 + * + * Единственное, есть проблема при срабатывании insets в landscape ориентации экрана (https://github.com/VKCOM/VKUI/issues/2422). + */ left: auto; z-index: 3; padding-left: var(--safe-area-inset-left);