Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1093: Компонент Snackbar не отображается поверх модального окона #1217

Closed
wants to merge 1 commit into from
Closed

#1093: Компонент Snackbar не отображается поверх модального окона #1217

wants to merge 1 commit into from

Conversation

thoughtspile
Copy link
Contributor

@thoughtspile thoughtspile commented Dec 8, 2020 •
edited
Loading

Не уверен, что это того стоило, но получается так. Также не уверен, что мне вообще нравится апи снекбара, где нужно его рендерить руками

@thoughtspile thoughtspile changed the title vkcom/vkui#1093: Move Snackbar above modal & popouts #1093: Компонент Snackbar не отображается поверх модального окона Dec 8, 2020
@thoughtspile thoughtspile marked this pull request as ready for review December 8, 2020 16:56
@thoughtspile thoughtspile requested a review from a team as a code owner December 8, 2020 16:56
@thoughtspile thoughtspile linked an issue Dec 8, 2020 that may be closed by this pull request
Компонент Snackbar не отображается поверх модального окона #1093
Open
NekR
NekR suggested changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@NekR NekR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давайте не будем переделывать API Snackbar сейчас уже. Переделаем с общей системой модалок и view.

@NekR
Copy link
Contributor

NekR commented Dec 19, 2020

Обычный CSS фикс есть в этом ПРе #1160

ArthurStam
ArthurStam suggested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ArthurStam ArthurStam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше сделать как обсуждали. В Root, View и PopoutWrapper добавить свойство snackbar по аналогии с modal и popout

@thoughtspile
Copy link
Contributor Author

закрываю — альтернативное решение в #1160

@SevereCloud SevereCloud deleted the vkui-1093 branch September 9, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NekR NekR NekR requested changes

@ArthurStam ArthurStam ArthurStam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Компонент Snackbar не отображается поверх модального окона
3 participants
@thoughtspile @NekR @ArthurStam