fix(ActionSheet): fix overflow for adroid and ios #3504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndreyZlobin
commented
Oct 25, 2022
AndreyZlobin
commented
- Добавил max-height: 100% для PopoutWrapper , а так же overflow:auto для ActionSheet, тем самым, получили скролл в ActionSheet на мобильных IOS и Android
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a3c921:
|
size-limit report 📦
|
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/3504/ |
inomdzhon
requested changes
Oct 31, 2022
There was a problem hiding this comment.
- Нужен ещё дизайн-ревью. Надо воссоздать кейс, приложить ссылку на этот кейс и добавить в ревьюеры группу @VKCOM/vkui-design.
- Сейчас правку легко сломать обратно, поэтому нужно обеспечить каким-то образом уменьшение вероятности этого (есть несколько вариантов).
|
Решение надо обсудить с дизайном, поэтому текущий PR закрываю |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.