Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Footer): fix design review notes #4627

Closed
wants to merge 2 commits into from
Closed

fix(Footer): fix design review notes #4627

wants to merge 2 commits into from

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul requested a review from a team as a code owner March 28, 2023 09:55
@BlackySoul BlackySoul linked an issue Mar 28, 2023 that may be closed by this pull request
[Bug]: Привести компонент Footer в соответствие с дизайном #3695
Open
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 28, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c034fbf:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and project coverage change: -27.55 ⚠️

Comparison is base (07489e8) 81.70% compared to head (c034fbf) 54.16%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4627       +/-   ##
===========================================
- Coverage   81.70%   54.16%   -27.55%     
===========================================
  Files         339      335        -4     
  Lines        8835     6526     -2309     
  Branches     2942     1848     -1094     
===========================================
- Hits         7219     3535     -3684     
- Misses       1616     2991     +1375
Flag Coverage Δ
a11ytests ?
e2e-chromium-android-dark ?
e2e-chromium-android-light 52.29% <75.00%> (+0.15%) ⬆️
e2e-chromium-vkcom-dark ?
e2e-chromium-vkcom-light 50.99% <75.00%> (+0.08%) ⬆️
e2e-firefox-vkcom-dark ?
e2e-firefox-vkcom-light ?
e2e-webkit-ios-dark 52.43% <75.00%> (+0.05%) ⬆️
e2e-webkit-ios-light ?
e2e-webkit-vkcom-dark ?
e2e-webkit-vkcom-light 51.08% <75.00%> (+0.11%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vkui/src/components/Footer/Footer.tsx 50.00% <66.66%> (-50.00%) ⬇️
packages/vkui/src/components/Group/Group.tsx 91.30% <100.00%> (-3.57%) ⬇️

... and 259 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 298.62 KB (+0.06% 🔺)
JS (gzip) 86.92 KB (+0.08% 🔺)
JS (brotli) 72.13 KB (+0.1% 🔺)
JS import Div (tree shaking) 2.94 KB (0%)
CSS 274.16 KB (+0.08% 🔺)
CSS (gzip) 35.25 KB (+0.04% 🔺)
CSS (brotli) 28.01 KB (+0.1% 🔺)

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4627/

SevereCloud
SevereCloud previously approved these changes Mar 28, 2023
View reviewed changes
inomdzhon
inomdzhon reviewed Mar 31, 2023
View reviewed changes
packages/vkui/src/components/Footer/Footer.tsx
export type FooterProps = React.AllHTMLAttributes<HTMLElement> & HasComponent;
export type FooterProps = React.AllHTMLAttributes<HTMLElement> &
HasComponent & {
mode?: 'group' | 'list' | 'loader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group и list это ассоциации с названиями компонентов? ты если использую внутри Group, то надо передать mode="group" и т.д.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде бы логика такая, да х)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот так может попробовать?

.Footer {
  --vkui_internal--footer_padding: 24px var(--vkui--size_base_padding_horizontal--regular);

  padding: var(--vkui_internal--footer_padding);
  /* TODO v6: переделать в List на padding */
  margin: var(--vkui_internal--footer_margin);
  text-align: var(--vkui_internal--footer_text-align, center); 
}
.Group {
  --vkui_internal--footer_padding: 4px var(--vkui--size_base_padding_horizontal--regular) 0;
  --vkui_internal--footer_text-align: left;
}
.List {
  --vkui_internal--footer_padding: 0;
    /* TODO v6: переделать в List на padding */
  --vkui_internal--footer_margin: 24px var(--vkui--size_base_padding_horizontal--regular);
}

@BlackySoul BlackySoul force-pushed the fix/3695/Footer_fix_design branch from 743d2ca to c034fbf Compare April 3, 2023 05:13
eugpoloz
eugpoloz reviewed Apr 3, 2023
View reviewed changes
packages/vkui/src/components/Footer/Footer.tsx
Comment on lines +7 to +9
export type FooterProps = React.AllHTMLAttributes<HTMLElement> &
HasComponent & {
mode?: 'group' | 'list' | 'loader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может, заодно с type на interface переделаем, раз появилось свое свойство?

Suggested change
export type FooterProps = React.AllHTMLAttributes<HTMLElement> &
HasComponent & {
mode?: 'group' | 'list' | 'loader';
export interface FooterProps extends React.AllHTMLAttributes<HTMLElement>, HasComponent {
mode?: 'group' | 'list' | 'loader';
}

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 11, 2023
@github-actions
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Apr 19, 2023
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 10, 2023
@BlackySoul BlackySoul reopened this May 10, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 17, 2023
@github-actions
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this May 24, 2023
@BlackySoul BlackySoul deleted the fix/3695/Footer_fix_design branch December 18, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon left review comments

@eugpoloz eugpoloz eugpoloz left review comments

@SevereCloud SevereCloud SevereCloud left review comments

Assignees
No one assigned
Labels
pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Привести компонент Footer в соответствие с дизайном
4 participants
@BlackySoul @inomdzhon @SevereCloud @eugpoloz