Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: animated Counter #4388

Closed
wants to merge 7 commits into from
Closed

Conversation

eugpoloz
Copy link
Contributor

@eugpoloz eugpoloz commented Mar 3, 2023

// TO DO: добавить полноценное описание


@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 36993ec:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

size-limit report 📦

Path Size
JS 300.41 KB (+0.69% 🔺)
JS (gzip) 87.44 KB (+0.72% 🔺)
JS (brotli) 72.54 KB (+0.9% 🔺)
JS import Div (tree shaking) 2.94 KB (0%)
CSS 274.7 KB (+0.3% 🔺)
CSS (gzip) 35.37 KB (+0.44% 🔺)
CSS (brotli) 28.1 KB (+0.52% 🔺)

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (10e0c09) 81.76% compared to head (eb0540e) 81.43%.
Report is 1096 commits behind head on master.

❗ Current head eb0540e differs from pull request most recent head 36993ec. Consider uploading reports for the commit 36993ec to get more accurate results

Files Patch % Lines
packages/vkui/src/components/Counter/Counter.tsx 43.58% 22 Missing ⚠️
packages/vkui/src/components/Value/Value.tsx 51.21% 20 Missing ⚠️
packages/vkui/src/lib/utils.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
- Coverage   81.76%   81.43%   -0.33%     
==========================================
  Files         340      342       +2     
  Lines        8877     8959      +82     
  Branches     2959     2975      +16     
==========================================
+ Hits         7258     7296      +38     
- Misses       1619     1663      +44     
Flag Coverage Δ
a11ytests ?
e2e-chromium-android-dark 51.98% <22.53%> (-0.33%) ⬇️
e2e-chromium-android-light 51.89% <22.53%> (-0.33%) ⬇️
e2e-chromium-vkcom-dark 50.69% <22.53%> (-0.41%) ⬇️
e2e-chromium-vkcom-light 50.78% <22.53%> (-0.32%) ⬇️
e2e-firefox-vkcom-dark 50.69% <22.53%> (-0.32%) ⬇️
e2e-firefox-vkcom-light 50.69% <22.53%> (-0.32%) ⬇️
e2e-webkit-ios-dark 52.12% <22.53%> (-0.33%) ⬇️
e2e-webkit-ios-light 52.12% <22.53%> (-0.33%) ⬇️
e2e-webkit-vkcom-dark 50.75% <22.53%> (-0.35%) ⬇️
e2e-webkit-vkcom-light 50.75% <22.53%> (-0.35%) ⬇️
unittests 77.61% <47.19%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4388/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Changed screenshots

⚠️ 60 changed screenshots found — review & update them via "Update Screenshots" action before merging.

button-android-chromium-dark-1-snap
button-android-chromium-light-1-snap
button-ios-webkit-dark-1-snap
button-ios-webkit-light-1-snap
button-vkcom-chromium-dark-1-snap
button-vkcom-chromium-light-1-snap
button-vkcom-firefox-dark-1-snap
button-vkcom-firefox-light-1-snap
button-vkcom-webkit-dark-1-snap
button-vkcom-webkit-light-1-snap
counter-android-chromium-dark-1-snap
counter-android-chromium-light-1-snap
counter-ios-webkit-dark-1-snap
counter-ios-webkit-light-1-snap
counter-vkcom-chromium-dark-1-snap
counter-vkcom-chromium-light-1-snap
counter-vkcom-firefox-dark-1-snap
counter-vkcom-firefox-light-1-snap
counter-vkcom-webkit-dark-1-snap
counter-vkcom-webkit-light-1-snap
header-android-chromium-dark-1-snap
header-android-chromium-light-1-snap
header-ios-webkit-dark-1-snap
header-ios-webkit-light-1-snap
header-vkcom-chromium-dark-1-snap
header-vkcom-chromium-light-1-snap
header-vkcom-firefox-dark-1-snap
header-vkcom-firefox-light-1-snap
header-vkcom-webkit-dark-1-snap
header-vkcom-webkit-light-1-snap
subnavigationbutton-android-chromium-dark-1-snap
subnavigationbutton-android-chromium-light-1-snap
subnavigationbutton-ios-webkit-dark-1-snap
subnavigationbutton-ios-webkit-light-1-snap
subnavigationbutton-vkcom-chromium-dark-1-snap
subnavigationbutton-vkcom-chromium-light-1-snap
subnavigationbutton-vkcom-firefox-dark-1-snap
subnavigationbutton-vkcom-firefox-light-1-snap
subnavigationbutton-vkcom-webkit-dark-1-snap
subnavigationbutton-vkcom-webkit-light-1-snap
tabs-android-chromium-dark-1-snap
tabs-android-chromium-light-1-snap
tabs-ios-webkit-dark-1-snap
tabs-ios-webkit-light-1-snap
tabs-vkcom-chromium-dark-1-snap
tabs-vkcom-chromium-light-1-snap
tabs-vkcom-firefox-dark-1-snap
tabs-vkcom-firefox-light-1-snap
tabs-vkcom-webkit-dark-1-snap
tabs-vkcom-webkit-light-1-snap
writebaricon-android-chromium-dark-1-snap
writebaricon-android-chromium-light-1-snap
writebaricon-ios-webkit-dark-1-snap
writebaricon-ios-webkit-light-1-snap
writebaricon-vkcom-chromium-dark-1-snap
writebaricon-vkcom-chromium-light-1-snap
writebaricon-vkcom-firefox-dark-1-snap
writebaricon-vkcom-firefox-light-1-snap
writebaricon-vkcom-webkit-dark-1-snap
writebaricon-vkcom-webkit-light-1-snap

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 11, 2023
@eugpoloz eugpoloz force-pushed the eugpoloz/4256-Counter-animated branch from 6ba09b7 to 83137fe Compare March 13, 2023 09:43
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 13, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 20, 2023
@eugpoloz eugpoloz force-pushed the eugpoloz/4256-Counter-animated branch from 83137fe to 2220096 Compare March 22, 2023 09:47
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 22, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 30, 2023
@eugpoloz eugpoloz force-pushed the eugpoloz/4256-Counter-animated branch from 2220096 to eb0540e Compare March 31, 2023 14:28
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 1, 2023
@eugpoloz eugpoloz added the no-stale Добавляет PR в исключения для автоматического закрытия label Apr 3, 2023
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@SevereCloud SevereCloud removed the v5 Автоматизация: PR продублируется в ветку v5 label Jan 25, 2024
@inomdzhon inomdzhon closed this Aug 14, 2024
@inomdzhon inomdzhon deleted the eugpoloz/4256-Counter-animated branch August 14, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Добавить анимацию изменения значения в Counter
3 participants