Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Улучшенная типизация полиморфных компонентов #4845

Closed
wants to merge 5 commits into from
Closed

feat(types): Улучшенная типизация полиморфных компонентов #4845

wants to merge 5 commits into from

Conversation

eugpoloz
Copy link
Contributor

@eugpoloz eugpoloz commented Apr 14, 2023 •
edited
Loading

  • Добавила новый тип HasComponentProps
  • Добавила хелпер polymorphicComponent в юнит-тесты
  • Перевела на HasComponentProps:
    • FocusTrap
    • Footer
    • FormField
    • FormItem
    • Header
    • HorizontalCell
    • PanelHeader
    • SimpleCell
    • SubnavigationButton
    • TabbarItem
    • Tappable
    • Touch
    • типографические компоненты
  • Проверила работу с forwardRef

    Можешь ещё потестить с forwardRef плиз? Помню были проблемы с женерик типами при обёртке в неё

@eugpoloz eugpoloz added the types label Apr 14, 2023
@eugpoloz eugpoloz self-assigned this Apr 14, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 298.71 KB (-0.01% 🔽)
JS (gzip) 87.42 KB (-0.01% 🔽)
JS (brotli) 72.61 KB (+0.07% 🔺)
JS import Div (tree shaking) 2.94 KB (0%)
CSS 276.52 KB (0%)
CSS (gzip) 35.52 KB (0%)
CSS (brotli) 28.17 KB (0%)

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit c6e20ce

@eugpoloz eugpoloz removed the types label Apr 14, 2023
@eugpoloz eugpoloz removed their assignment Apr 14, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this May 2, 2023
@eugpoloz eugpoloz removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Улучшить типизацию полиморфных компонентов
1 participant
@eugpoloz