fix(HorizontalScroll): support rtl #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07cb92b:
|
e2e tests |
👀 Docs deployed
Commit 07cb92b |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5842 +/- ##
==========================================
+ Coverage 79.16% 79.17% +0.01%
==========================================
Files 303 304 +1
Lines 9482 9507 +25
Branches 3208 3216 +8
==========================================
+ Hits 7506 7527 +21
- Misses 1976 1980 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mendrew
reviewed
Sep 21, 2023
packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
Outdated
Show resolved
Hide resolved
SevereCloud
added
the
patch
SevereCloud
force-pushed
the
SevereCloud/issue5837
branch
from
f8a6f63 to
670d042
Compare
mendrew
reviewed
Oct 3, 2023
mendrew
approved these changes
Oct 3, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 3, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Unit-тесты(getComputedStyle не работает в юнит тестах)[ ] e2e-тесты[ ] Дизайн-ревьюОписание
Исправляем HorisontalScroll для RTL
Изменения
Добавлен хук
useDirectionдля определения направления текста. Исправлена работа стрелок в rtl