Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Изменить токен для Tabs / Mode=Accent #5872

Open
Zaycevq opened this issue Sep 26, 2023 · 1 comment
Open

[Feature]: Изменить токен для Tabs / Mode=Accent #5872

Zaycevq opened this issue Sep 26, 2023 · 1 comment
Assignees
@Zaycevq
Labels
cmp:tabs cmp:tabs-item design Нужно участие команды дизайна type:feature

Comments

@Zaycevq
Copy link

Zaycevq commented Sep 26, 2023

Описание

Текущий токен для Accent Tabs в тёмной теме плохо считывается на vkCom background_content и вообще не виден на всех платформах поверх модальных окон.

Требуется поменять на токен:
colorBackgroundContrastThemed: {
light: '#FFFFFF',
dark: '#323232',

bad_tabs_modal

Скриншоты

No response
@Zaycevq Zaycevq added this to VKUI Sep 26, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Sep 26, 2023
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔜 To do in VKUI Oct 16, 2023
@inomdzhon inomdzhon moved this from 🔜 To do to 🔧 In progress in VKUI Nov 16, 2023
@inomdzhon inomdzhon added this to the v5.10.0 milestone Nov 16, 2023
@inomdzhon inomdzhon mentioned this issue Nov 16, 2023
Closed
2 tasks
@inomdzhon inomdzhon moved this from 🔧 In progress to 👀 In Review in VKUI Nov 16, 2023
@inomdzhon inomdzhon removed this from the v5.10.0 milestone Nov 24, 2023
@inomdzhon inomdzhon moved this from 👀 In Review to 🔜 To do in VKUI Nov 24, 2023
@inomdzhon inomdzhon added the design Нужно участие команды дизайна label Nov 24, 2023
@inomdzhon
Copy link
Contributor

inomdzhon commented Nov 24, 2023 •
edited
Loading

Теперь не контрастирует с ScrollArrow, если оборачивать в HorizontalScroll

Если для ScrollArrow применять такой же токен colorBackgroundContrastThemed, то тогда будет не контрастно выглядеть в контексте CardScroll:

Нужна доработка по дизайну.

@inomdzhon inomdzhon assigned Zaycevq and unassigned inomdzhon Nov 24, 2023
@inomdzhon inomdzhon moved this from 🔜 To do to 🗃 Backlog in VKUI Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zaycevq Zaycevq

Labels
cmp:tabs cmp:tabs-item design Нужно участие команды дизайна type:feature
Projects
VKUI
Status: 🗃 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(TabsItem): change bg token for mode accent VKCOM/VKUI
2 participants
@inomdzhon @Zaycevq