Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TabsItem): change bg token for mode accent #6115

Closed
wants to merge 2 commits into from
Closed

feat(TabsItem): change bg token for mode accent #6115

wants to merge 2 commits into from

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Nov 16, 2023 •
edited by Zaycevq
Loading

  • e2e-тесты – необходимо обновить скриншоты
  • Дизайн-ревью

Описание

Используем более контрастный цвет.

@inomdzhon
feat(TabsItem): change bg token for mode accent
e9d9e79 
Используем более контрастный.
@inomdzhon inomdzhon requested a review from a team as a code owner November 16, 2023 10:40
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 336.39 KB (0%)
JS (gzip) 102.75 KB (0%)
JS (brotli) 84.75 KB (0%)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.26 KB (+0.01% 🔺)
CSS (gzip) 33.58 KB (+0.02% 🔺)
CSS (brotli) 27.25 KB (-0.01% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 16, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50564a7:

Sandbox Source
VKUI TypeScript Configuration

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit e9d9e79

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (107c29d) 79.38% compared to head (e9d9e79) 79.38%.
Report is 140 commits behind head on master.

❗ Current head e9d9e79 differs from pull request most recent head 50564a7. Consider uploading reports for the commit 50564a7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6115   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files         306      306           
  Lines        9631     9631           
  Branches     3261     3261           
=======================================
  Hits         7646     7646           
  Misses       1985     1985
Flag Coverage Δ
unittests 79.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BlackySoul
BlackySoul previously approved these changes Nov 16, 2023
View reviewed changes
@inomdzhon inomdzhon marked this pull request as draft November 24, 2023 09:02
@inomdzhon inomdzhon removed the v5 Автоматизация: PR продублируется в ветку v5 label Nov 30, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 7, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 15, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Dec 31, 2023
@inomdzhon inomdzhon deleted the imirdzhamolov/issue5872/feat/TabBarIteam-color branch January 25, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendrew mendrew mendrew approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

@BlackySoul BlackySoul BlackySoul left review comments

Assignees
No one assigned
Labels
pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Изменить токен для Tabs / Mode=Accent
5 participants
@inomdzhon @mendrew @BlackySoul @SevereCloud @actions-user