Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator should check if ROM exists #60

Open
KR155E opened this issue Jan 19, 2023 · 3 comments
Open

Emulator should check if ROM exists #60

KR155E opened this issue Jan 19, 2023 · 3 comments
Milestone

Comments

@KR155E
Copy link
Member

KR155E commented Jan 19, 2023

When loading the emulator widget, check if the ROM file (still) exists. If not, mark file as deleted? Close emulator? Show error message? TBD

@KR155E KR155E added this to the 1.0.0 milestone Jan 19, 2023
@jorgeche
Copy link
Member

I'm not sure what "loading the emulator widget" entails. I see the widget at the right side of the window all the time. At the moment, when I hit the Play button, if there is no ROM, the building process start, which is the expected behavior.

@KR155E
Copy link
Member Author

KR155E commented Jan 19, 2023

I am referring to the widget that is the actual emulator itself. Not the sidebar widget. Here's an example for a scenario that is currently not optimally handled:

  • You start the game via the run command (or use VES to play any other Virtual Boy ROM file)
  • You quit VES
  • You delete the ROM you previously loaded in VES, for example if you tested a random ROM and remove it after the test
  • You start VES again
  • It will load the previously opened tabs, including the one holding the emulator for the deleted ROM
  • No ROM can be found and an empty string is fed to the emulator, whose window just stays black

@jorgeche
Copy link
Member

I would simply close the tab. When I open a ROM, I don't think of it as a file, but as a running game; and a running game is an ephemeral thing. Not only that, I would close the emulator's tab even if the ROM exists because the it uses quite a bit of CPU and having it running automatically in a tab that may not be visible if I had tons of others before closing VES, it would be wasting resources until I launch the emulator again or find about it running already.

@KR155E KR155E modified the milestones: 1.0.0, 1.1.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants