Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the "File Open" dialog refuses to work #6372

Open
CouleeApps opened this issue Jan 28, 2025 · 3 comments
Open

Sometimes the "File Open" dialog refuses to work #6372

CouleeApps opened this issue Jan 28, 2025 · 3 comments
Labels
Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps

Comments

@CouleeApps
Copy link
Member

CouleeApps commented Jan 28, 2025

Version and Platform (required):

  • Binary Ninja Version: 4.3.6766-dev
  • OS: macOS
  • OS Version: 15.2
  • CPU Architecture: arm64

Bug Description:
Sometimes trying to use Cmd+O to open a file refuses to work. Every time the dialog opens, it just closes itself. This persists across binja restarts until I reboot my entire computer or until some mystery amount of time has passed and then it just decides to work again. I haven't been able to reliably reproduce it or figure out why it happens when it does.

Steps To Reproduce:

  1. ???
  2. Try to open a file
  3. Window closes before i can pick a file

Expected Behavior:
I expected the window to stay open

Screenshots/Video Recording:
https://github.com/user-attachments/assets/e21502bf-313b-4a50-b259-f84bc60c5a71

Additional Information:
Every time this happens, I get the following errors in stderr:

2025-01-28 17:38:31.307586-0500 binaryninja[64556:6802532] [OpenSavePanels] Ignoring NSSavePanel method sent to NSOpenPanel: setNameFieldStringValue:
2025-01-28 17:38:31.424366-0500 binaryninja[64556:6802532] [availability] Can't find or decode accessNotGrantedUseCases
2025-01-28 17:38:31.425739-0500 binaryninja[64556:6802532] [availability] Can't find or decode accessNotGrantedUseCases

This might be a Qt bug but it's hard to tell.

@CouleeApps CouleeApps added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround labels Jan 28, 2025
@CouleeApps
Copy link
Member Author

Todo: when it happens next, try running the following simple Qt application and seeing if it also applies to other Qt applications (would indicate this is a Qt bug and not our bug):

qtbugmaybe.zip

cmake -B build6.7.2 -DCMAKE_PREFIX_PATH=$HOME/Qt/6.7.2/clang_64/lib/cmake
cmake --build build6.7.2
./build6.7.2/qtbug1111111

@CouleeApps
Copy link
Member Author

Well it reproed again and that sample bin did not exhibit the same behavior. The mystery continues...

@CouleeApps
Copy link
Member Author

CouleeApps commented Feb 6, 2025

Reproed again, tried commenting out uses of windowhacks.mm and somehow, the file named hacks is not the culprit this time. Nor is it the QApplication::focusChanged events.

Also a different Qt application worked totally fine. Whattt

Also it is only OPEN panels, save panes are totally fine

Running execute_on_main_thread(lambda: QFileDialog.getOpenFileName(None, "Open pls", "~/", "*.png")) in the console is also broken

Looks like the call to QFileDialog::exec is returning something other than Accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Development

No branches or pull requests

1 participant