Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate WARP Tags Created on Subsequent Run Matcher #6406

Open
utkonos opened this issue Feb 8, 2025 · 1 comment
Open

Duplicate WARP Tags Created on Subsequent Run Matcher #6406

utkonos opened this issue Feb 8, 2025 · 1 comment
Assignees
@emesare
Labels
Component: WARP Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround UI: Tags Issues with the Tags widget
Milestone
H

Comments

@utkonos
Copy link
Contributor

utkonos commented Feb 8, 2025

Version and Platform (required):

  • Binary Ninja Version: 4.2.6455
  • OS: macOS
  • OS Version: 15.3
  • CPU Architecture: x64

Bug Description:
I clicked Run Matcher in WARP and it created a second tag for every single function matched.

Steps To Reproduce:

  1. Click Run Matcher again after it has run once.

Expected Behavior:
Any functions that were not matched in the first run would potentially be matched in the second if something in the database had changed so that the matches would work the second time. But not duplication of everything.

Screenshots/Video Recording:

Image Image
@utkonos
Copy link
Contributor Author

utkonos commented Feb 8, 2025

Thank goodness for history and being able to go backwards 💪

Image

@emesare emesare self-assigned this Feb 8, 2025
@emesare emesare added Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day UI: Tags Issues with the Tags widget Component: WARP labels Feb 8, 2025
@emesare emesare added this to the Gallifrey milestone Feb 10, 2025
@plafosse plafosse modified the milestones: Gallifrey, H Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emesare emesare

Labels
Component: WARP Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround UI: Tags Issues with the Tags widget
Projects
None yet
Milestone
H
Development

No branches or pull requests
3 participants
@utkonos @plafosse @emesare