Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation sometimes goes to a wrong address #6410

Closed
xusheng6 opened this issue Feb 11, 2025 · 7 comments
Closed

Navigation sometimes goes to a wrong address #6410

xusheng6 opened this issue Feb 11, 2025 · 7 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Critical Issue blocks CRITICAL functionality UI: Linear Issues with the Linear view
Milestone

Comments

@xusheng6
Copy link
Member

I noticed recently that, when I double-click an address to navigate, it sometimes goes to the wrong address in linear view. I have not figured out when it happens, but it is pretty annoying and I believe should be treated with priority

@xusheng6 xusheng6 added this to the Gallifrey milestone Feb 11, 2025
@xusheng6 xusheng6 added the Impact: High Issue adds or blocks important functionality label Feb 11, 2025
@plafosse plafosse added the Component: UI Issue needs changes to the user interface label Feb 11, 2025
@uniquadev
Copy link

binaryninja_AZlcEowcCG.mp4

@psifertex
Copy link
Member

Thanks! Can you confirm which version you reproduced that on?

@galenbwill
Copy link
Contributor

I have also observed this, but afaict, the misnavigation only happens in the disassembly view. It also seems to apply to view syncing, but I haven't verified that on latest dev.

@galenbwill
Copy link
Contributor

Oh, I should add that I noticed that it seems to happen iff the cursor has to cross a basic block boundary from its current position to the navigation target.

@xusheng6 xusheng6 added UI: Linear Issues with the Linear view Effort: Low Issue should take < 1 week labels Feb 18, 2025
@uniquadev
Copy link

Thanks! Can you confirm which version you reproduced that on?

4.3.6881-dev windows personal

@plafosse plafosse added Impact: Critical Issue blocks CRITICAL functionality and removed Impact: High Issue adds or blocks important functionality labels Feb 18, 2025
@psifertex
Copy link
Member

Thanks -- as you can tell from the tags Peter just added we consider this a high priority bug and will be making sure it's solved before the next stable.

@fuzyll
Copy link
Contributor

fuzyll commented Feb 18, 2025

@rssor's fix for this should be in builds >= 4.3.6893-dev. Waiting for confirmation from a few users before I close this, however.

@fuzyll fuzyll closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Critical Issue blocks CRITICAL functionality UI: Linear Issues with the Linear view
Projects
None yet
Development

No branches or pull requests

6 participants