[test] introduce script scopes around expensive memory tests #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it help to split up these tests into multiple |
|
Personally, I'm not a big fan of having a gazillion micro test files. But in any case, these are generated, so that would require a more significant rewrite of the JS generator scripts, that somebody would have to volunteer doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1698. This tweaks the generators for bulk memory/table tests to insert
(script ...)scopes around tests and extends the JS converter to turn these into block scopes.This is likely to break existing .wast consumers that do not recognise
scriptscopes. The simplest fix is to ignore them by treating them as equivalent to their contents.